beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] incubator-beam pull request #1319: Misc improvements
Date Wed, 09 Nov 2016 18:10:33 GMT
GitHub user tgroh opened a pull request:

    Misc improvements

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    We don't ever reference the thread a TransformExecutor is using, so remove it.
    Short-circuit TimerInternals.compareTo if the two namespaces are equal.

You can merge this pull request into a Git repository by running:

    $ git pull misc_improvements

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1319
commit fd0b4cacc5c63f4218ffcbd4fec646233fc7a2b7
Author: Thomas Groh <>
Date:   2016-11-08T22:16:23Z

    Remove unused Thread variable in TransformExecutor

commit c39fcfd11ac95fa70ce15071cbd8a72b288e58bc
Author: Thomas Groh <>
Date:   2016-11-08T22:18:58Z

    Reduce incidence of Namespace StringKey comparisons
    If the Namespace of a TimerData reports itself as being equal to the
    other namespace, immediately return 0 rather than generating the string
    keys and comparing them.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message