beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1308: [BEAM-939] Use the credentials from GcpOp...
Date Tue, 08 Nov 2016 04:01:22 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/1308

    [BEAM-939] Use the credentials from GcpOptions instead of relying on BigtableOptions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This allows for us to create a version of the service depending on the PipelineOptions
passed in at this time. This uses a function which takes in the contextual PipelineOptions
and creates a service from it allowing us to not serialize the Credentials within the BigtableOptions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam beam939

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1308
    
----
commit 5fd9cdc0c843cf126ce0f2e6c6c7563471d6b335
Author: Luke Cwik <lcwik@google.com>
Date:   2016-11-08T03:37:42Z

    [BEAM-939] Use the credentials from GcpOptions instead of relying on the BigtableOptions
to provide them.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message