beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] incubator-beam pull request #1287: Use Coarser Updates in WatermarkManager
Date Fri, 04 Nov 2016 22:42:50 GMT
GitHub user tgroh opened a pull request:

    Use Coarser Updates in WatermarkManager

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Rather than tracking elements independently, track the bundles that are pending.
    Incrementally update pending elements when work completes. Attempt to obtain the
    lock whenever work completes and do a small amount of maintenance work, but do
    nothing if the lock is not immediately available.

You can merge this pull request into a Git repository by running:

    $ git pull incremental_pending_elements

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1287
commit 1eb110384417924f5cc4f64ce887724807c6941d
Author: Thomas Groh <>
Date:   2016-11-04T18:28:03Z

    Incrementally update Pending elements when work completes
    This reduces the amount of single-threaded updates the monitor thread
    performs before firing timers.

commit b1400c905ccbf6b6887c1dcd4e65157e5bc357c1
Author: Thomas Groh <>
Date:   2016-11-04T19:54:00Z

    Track Minimum Element Timestamps within Bundles
    This allows the Watermark Manager to track pending elements by bundles
    of elements rather than per-element, which significantly reduces the
    amount of work done per-element to track watermarks.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message