beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhalperi <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1285: checkstyle: move from individual modules ...
Date Fri, 04 Nov 2016 16:53:19 GMT
GitHub user dhalperi opened a pull request:

    https://github.com/apache/incubator-beam/pull/1285

    checkstyle: move from individual modules to root poms

    Checkstyle config is no longer needed in individual modules;
    instead, move it only to sdks/ , runners/, and examples/ poms.
    Individual modules like sdks/java/core may still reference checkstyle
    to configure their own options.
    
    The only sketchy bit is that I had to link sdks/java/build-tools to
    beam-parent rather than sdks/java so that I didn't create a build
    dependency loop.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1285
    
----
commit 93d1a267b326ff3f4bea9614752c6a147476af6e
Author: Dan Halperin <dhalperi@google.com>
Date:   2016-11-04T00:24:52Z

    checkstyle: move from individual modules to root poms
    
    Checkstyle config is no longer needed in individual modules;
    instead, move it only to sdks/ , runners/, and examples/ poms.
    Individual modules like sdks/java/core may still reference checkstyle
    to configure their own options.
    
    The only sketchy bit is that I had to link sdks/java/build-tools to
    beam-parent rather than sdks/java so that I didn't create a build
    dependency loop.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message