beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <>
Subject [GitHub] incubator-beam pull request #1268: Allow an option to not flatten record typ...
Date Thu, 03 Nov 2016 00:47:16 GMT
GitHub user sb2nov opened a pull request:

    Allow an option to not flatten record types in BQ

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    - Add a flag to BQ source so that we can allow for record type to not be flattened
    - Change the BQReader so that DirectRunner parses the dictionaries correctly
    - Add tests to make sure that dict parsing is working correctly
    Future work:
    - This has a lot of conflicts with #1242 so will be updated after that has been merged
into master.
    - Write an integration test so that can check the cleanup of temporary datasets correctly,
for now verified this manually
    R: @chamikaramj PTAL

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-877-disallow-record-flattening

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1268
commit 73cab2dceace94f41f8a78494bc0ba1615ba7a16
Author: Sourabh Bajaj <>
Date:   2016-11-03T00:42:06Z

    Allow an option to not flatten records in BQ


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message