beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1258: Add Tests for PAssert.IterableAssert#empt...
Date Wed, 02 Nov 2016 17:37:02 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1258

    Add Tests for PAssert.IterableAssert#empty()

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    These tests demonstrate that an empty PCollection has no elements, and
    that the empty() assertion affirmatively fails when there are elements
    within the PCollection.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam passert_empty_tests-backup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1258
    
----
commit 656591742bc4b51095ea932d9b75d5c2cc342a6f
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-02T17:35:27Z

    Add Tests for PAssert.IterableAssert#empty()
    
    These tests demonstrate that an empty PCollection has no elements, and
    that the empty() assertion affirmatively fails when there are elements
    within the PCollection.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message