beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1252: [BEAM-27] Factor of parameter analysis in...
Date Tue, 01 Nov 2016 22:42:40 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-27] Factor of parameter analysis in DoFnSignatures; use it for @OnTimer methods

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    R: @jkff 
    This might be easiest to review as individual commits, though the last one is the goal
of this PR.
    This PR is a prefix of ongoing work to invoke `@OnTimer` methods. I've peeled it off and
fixed it up and added a smidge of testing. Since the code is entirely shared, just making
sure the right path is taken provides moderate coverage. (a further refactor could make this
clearer, by isolating the shared code into a class with its own unit tests, absolving its
callers of proving they exercise the code path, but I thought this baby step was better)

You can merge this pull request into a Git repository by running:

    $ git pull DoFnSignatures

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1252
commit 5946ec175d55f9164f9b1b34a06539da3c24f5ae
Author: Kenneth Knowles <>
Date:   2016-11-01T04:30:40Z

    Refactor and reuse parameter analysis in DoFnSignatures

commit 15a8901ade07c1649378a0b72238eb514877c61c
Author: Kenneth Knowles <>
Date:   2016-11-01T21:48:54Z

    Switch DoFnSignature, etc, from TypeToken to TypeDescriptor

commit 6de216695c05e4d9b283f0842aed8713075be7aa
Author: Kenneth Knowles <>
Date:   2016-11-01T21:50:24Z

    DoFnSignature: Make TypeDescriptor-returning methods public

commit 40bbfff3dba803951607ae15d5d2cf99fbe64a32
Author: Kenneth Knowles <>
Date:   2016-11-01T22:38:01Z

    Add TypeDescriptor#getTypes


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message