beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1251: [BEAM-788] Implement GroupAlsoByWindowsEv...
Date Tue, 01 Nov 2016 21:50:50 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1251

    [BEAM-788] Implement GroupAlsoByWindowsEvaluator Directly

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Invoke the ReduceFnRunner methods directly rather than by constructing a
    GroupAlsoByWindowDoFn and a ParDoEvaluator. Instead, construct a
    ReduceFnRunner, ReduceFn, and invoke the methods directly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam gabw_implemented_directly

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1251
    
----
commit 1cd3dbc5fd35748751c27e17def6100d591ff043
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-01T21:29:48Z

    Implement GroupAlsoByWindowsEvaluator Directly
    
    Invoke the ReduceFnRunner methods directly rather than by constructing a
    GroupAlsoByWindowDoFn and a ParDoEvaluator. Instead, construct a
    ReduceFnRunner, ReduceFn, and invoke the methods directly.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message