beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1243: Fixes crash of shade plugin on SparkProce...
Date Tue, 01 Nov 2016 01:09:16 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1243

    Fixes crash of shade plugin on SparkProcessContext

    Error discovered by debugging the Maven plugin itself
    (using mvnDebug) and setting a breakpoint for the exception
    and then inspecting the call stack to spot a weird-looking
    method signature descriptor:
    
    `Lorg/apache/beam/sdk/transforms/windowing/WindowFn<Ljava/lang/Object;!*>.AssignContext;`
    
    (note the exclamation mark, which is an invalid character AFAIK!
    I have no idea where it came from, but the current change makes it go away)
    
    R: @dhalperi 
    CC: @amitsela 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam spark-process-context-shade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1243
    
----
commit fc8d49e86344ba97a032b19eed4f881c20f9805b
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-11-01T01:06:43Z

    Fixes crash of shade plugin on SparkProcessContext
    
    Error discovered by debugging the Maven plugin itself
    (using mvnDebug) and setting a breakpoint for the exception
    and then inspecting the call stack to spot a weird-looking
    method signature descriptor:
    
    `Lorg/apache/beam/sdk/transforms/windowing/WindowFn<Ljava/lang/Object;!*>.AssignContext;`
    
    (note the exclamation mark, which is an invalid character AFAIK!
    I have no idea where it came from, but the current change makes it go away)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message