beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-951) Cleanup FileBasedSink to prepare IOChannelFactory redesign.
Date Tue, 22 Nov 2016 07:21:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685940#comment-15685940
] 

ASF GitHub Bot commented on BEAM-951:
-------------------------------------

GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/1412

    [BEAM-951] IOChannelFactory: replace toPath() with resolveSibling() t…

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    …o tighten the interface.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam io-channel-factory-to-path

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1412
    
----
commit aabea4aef0a4369ebd2c90ed44e6a60443019e70
Author: Pei He <peihe@google.com>
Date:   2016-11-22T07:20:59Z

    [BEAM-951] IOChannelFactory: replace toPath() with resolveSibling() to tighten the interface.

----


> Cleanup FileBasedSink to prepare IOChannelFactory redesign.
> -----------------------------------------------------------
>
>                 Key: BEAM-951
>                 URL: https://issues.apache.org/jira/browse/BEAM-951
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core, sdk-java-gcp
>            Reporter: Pei He
>            Assignee: Pei He
>
> FileBasedSink uses both FileOperations and IOChannelFactory interfaces, and they need
to be merged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message