beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-937) The DirectRunner does not advance watermarks if reading from an empty reader
Date Mon, 07 Nov 2016 21:17:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645487#comment-15645487
] 

ASF GitHub Bot commented on BEAM-937:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1300

    [BEAM-937] Update Watermarks even if a Reader is empty

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This ensures that the pipeline will make progress even if a reader stops
    producing elements.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam always_update_ub_wms

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1300.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1300
    
----
commit b093dd821a61ee753ac21d56919c390c3b632a1b
Author: Thomas Groh <tgroh@google.com>
Date:   2016-11-07T20:59:06Z

    Update Watermarks even if a Reader is empty
    
    This ensures that the pipeline will make progress even if a reader stops
    producing elements.

----


> The DirectRunner does not advance watermarks if reading from an empty reader
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-937
>                 URL: https://issues.apache.org/jira/browse/BEAM-937
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message