beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-810) Beam's uses of archetypes are problematic
Date Fri, 04 Nov 2016 16:08:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636841#comment-15636841
] 

ASF GitHub Bot commented on BEAM-810:
-------------------------------------

GitHub user dhalperi reopened a pull request:

    https://github.com/apache/incubator-beam/pull/1284

    [BEAM-810] pom: move maven-archetypes to its proper spot in dep hierarchy

    R: @davorbonaci 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhalperi/incubator-beam maven-arch-pom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1284
    
----

----


> Beam's uses of archetypes are problematic
> -----------------------------------------
>
>                 Key: BEAM-810
>                 URL: https://issues.apache.org/jira/browse/BEAM-810
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>    Affects Versions: Not applicable
>            Reporter: Daniel Halperin
>
> * Using a version range in the archetype pom.xml is inaccurate, because we don't have
a stable API. We can't actually expect an older version to work as we make backwards-incompatible
changes.
> * In PR #936, a decision was made to pin the version of the archetype. This requires
manual changes to update many places (archetype-resources), which breaks the release process
in a few different ways. See [BEAM-806].
> * Travis uses `mvn verify`, not `mvn install` -- so archetypes are not properly tested
and instead we're actually picking up the SNAPSHOT archetypes deployed the prior night (IIRC).
> * There was some other issue with parallelizing maven where archetypes are not properly
marked as depending on "you can't test the archetype until you've installed the examples packages".
> * We're not actually testing that the archetype-generated projects actually compile.
[BEAM-641].
> This is all pretty ugly. Suggestions wanted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message