beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-694) Add TriggerTester methods to check that timers are set
Date Fri, 04 Nov 2016 18:13:58 GMT

     [ https://issues.apache.org/jira/browse/BEAM-694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kenneth Knowles updated BEAM-694:
---------------------------------
    Description: TriggerTester exposes a {{fireIfShouldFire(BoundedWIndow)}} method. This
is used to prompt a call to the trigger with the current state of the trigger tester (Input
Watermarks, elements present, etc), and see if the trigger should fire. This is sufficient
to test {{shouldFire}} of the {{TriggerStateMachine}} under test, but does not test that the
{{onElement}} method sets an appropriate timer to cause such an interrogation to occur.  (was:
TriggerTester exposes a `fireIfShouldFire(BoundedWIndow)` method. This is used to prompt a
call to the trigger with the current state of the trigger tester (Input Watermarks, elements
present, etc), and see if the trigger should fire.

The TriggerTester should automatically call back to the trigger with the current state whenever
a Timer fires, as specified by the current watermarks and any Timers set by the trigger under
test. This ensures that Triggers set underlying timers properly, so the trigger will fire
even if no additional elements arrive.)

> Add TriggerTester methods to check that timers are set
> ------------------------------------------------------
>
>                 Key: BEAM-694
>                 URL: https://issues.apache.org/jira/browse/BEAM-694
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Eugene Kirpichov
>            Priority: Minor
>              Labels: easy, starter
>
> TriggerTester exposes a {{fireIfShouldFire(BoundedWIndow)}} method. This is used to prompt
a call to the trigger with the current state of the trigger tester (Input Watermarks, elements
present, etc), and see if the trigger should fire. This is sufficient to test {{shouldFire}}
of the {{TriggerStateMachine}} under test, but does not test that the {{onElement}} method
sets an appropriate timer to cause such an interrogation to occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message