beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-230) Remove WindowedValue#valueInEmptyWindows
Date Tue, 29 Nov 2016 19:12:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706247#comment-15706247
] 

ASF GitHub Bot commented on BEAM-230:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1440


> Remove WindowedValue#valueInEmptyWindows
> ----------------------------------------
>
>                 Key: BEAM-230
>                 URL: https://issues.apache.org/jira/browse/BEAM-230
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>             Fix For: Not applicable
>
>
> A WindowedValue in no windows does not exist, and can be dropped by a runner at any time.
> We should also assert that any collection of windows is nonempty when creating a new
WindowedValue. If a user wants to drop an element, they should explicitly filter it out rather
than expecting it to be dropped by the runner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message