beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amits...@apache.org
Subject [2/3] incubator-beam git commit: Remove unused body of StreamingPCollectionViewWriterFn
Date Sat, 26 Nov 2016 11:00:39 GMT
Remove unused body of StreamingPCollectionViewWriterFn


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/07544ef3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/07544ef3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/07544ef3

Branch: refs/heads/master
Commit: 07544ef3a47bbdfacc00c75af875c3533a5fe477
Parents: 632576b
Author: Kenneth Knowles <klk@google.com>
Authored: Wed Nov 23 11:22:08 2016 -0800
Committer: Sela <ansela@paypal.com>
Committed: Sat Nov 26 12:47:14 2016 +0200

----------------------------------------------------------------------
 .../apache/beam/runners/dataflow/DataflowRunner.java  | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/07544ef3/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
----------------------------------------------------------------------
diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
index 36328e9..f1d41f2 100644
--- a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
+++ b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
@@ -2360,8 +2360,8 @@ public class DataflowRunner extends PipelineRunner<DataflowPipelineJob>
{
   }
 
   /**
-   * A specialized {@link DoFn} for writing the contents of a {@link PCollection}
-   * to a streaming {@link PCollectionView} backend implementation.
+   * A marker {@link DoFn} for writing the contents of a {@link PCollection} to a streaming
+   * {@link PCollectionView} backend implementation.
    */
   @Deprecated
   public static class StreamingPCollectionViewWriterFn<T>
@@ -2389,13 +2389,9 @@ public class DataflowRunner extends PipelineRunner<DataflowPipelineJob>
{
 
     @Override
     public void processElement(ProcessContext c) throws Exception {
-      List<WindowedValue<T>> output = new ArrayList<>();
-      for (T elem : c.element()) {
-        output.add(WindowedValue.of(elem, c.timestamp(), c.window(), c.pane()));
-      }
-
-      c.windowingInternals().writePCollectionViewData(
-          view.getTagInternal(), output, dataCoder);
+      throw new UnsupportedOperationException(
+          String.format(
+              "%s is a marker class only and should never be executed.", getClass().getName()));
     }
   }
 


Mime
View raw message