beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tg...@apache.org
Subject [1/2] incubator-beam git commit: Remove Pipeline#getFullNameForTesting
Date Wed, 16 Nov 2016 18:55:57 GMT
Repository: incubator-beam
Updated Branches:
  refs/heads/master 938ac91a9 -> c695ef48b


Remove Pipeline#getFullNameForTesting


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/1cdaa4e7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/1cdaa4e7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/1cdaa4e7

Branch: refs/heads/master
Commit: 1cdaa4e7beee025cdca1f14dddd56d4271635383
Parents: 938ac91
Author: Thomas Groh <tgroh@google.com>
Authored: Tue Nov 15 12:38:02 2016 -0800
Committer: Thomas Groh <tgroh@google.com>
Committed: Wed Nov 16 10:55:43 2016 -0800

----------------------------------------------------------------------
 .../main/java/org/apache/beam/sdk/Pipeline.java    | 17 -----------------
 1 file changed, 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/1cdaa4e7/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
index 2286832..e188b35 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/Pipeline.java
@@ -17,10 +17,7 @@
  */
 package org.apache.beam.sdk;
 
-import static com.google.common.base.Preconditions.checkState;
-
 import com.google.common.collect.HashMultimap;
-import com.google.common.collect.Iterables;
 import com.google.common.collect.Multimap;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -484,20 +481,6 @@ public class Pipeline {
   }
 
   /**
-   * @deprecated this method is no longer compatible with the design of {@link Pipeline},
-   * as {@link PTransform PTransforms} can be applied multiple times, with different names
-   * each time.
-   */
-  @Deprecated
-  public String getFullNameForTesting(PTransform<?, ?> transform) {
-    Collection<AppliedPTransform<?, ?, ?>> uses =
-        transformApplicationsForTesting.get(transform);
-    checkState(uses.size() > 0, "Unknown transform: " + transform);
-    checkState(uses.size() <= 1, "Transform used multiple times: " + transform);
-    return Iterables.getOnlyElement(uses).getFullName();
-  }
-
-  /**
    * Returns a unique name for a transform with the given prefix (from
    * enclosing transforms) and initial name.
    *


Mime
View raw message