Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: jkff <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-1225-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #1225: [BEAM-854] Removes ReifyTimestampsAndWind...
Content-Type: text/plain
Date: Fri, 28 Oct 2016 22:19:17 +0000 (UTC)
archived-at: Fri, 28 Oct 2016 22:19:22 -0000

GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1225

    [BEAM-854] Removes ReifyTimestampsAndWindows

    It was used effectively in 2 places:
    - GatherAllPanes (used in PAssert): replaced with a similar custom DoFn.
    - A couple of GBK-related transforms: folded into GroupByKeyOnly.
    
    Additionally, makes DirectGroupByKeyOnly produce globally-windowed KeyedWorkItem's - we already knew this was the right thing to do in general.
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam rm-reify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1225
    
----
commit 5382fd9b14efca03e8be1d36432bbbfb14b1a9fc
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-28T17:40:17Z

    [BEAM-854] Removes ReifyTimestampsAndWindows
    
    It was used effectively in 2 places:
    - GatherAllPanes (used in PAssert):
      replaced with a similar custom DoFn.
    - A couple of GBK-related transforms:
      folded into GroupByKeyOnly.

commit db6dabf44a12168941a34d202adf151b8191825a
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-10-28T22:16:01Z

    Also makes GBKO produce globally-windowed KWIs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---