Return-Path: <commits-return-12532-archive-asf-public=cust-asf.ponee.io@beam.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F0C6C200BAC
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 26 Oct 2016 23:55:47 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id EF6B1160AEE; Wed, 26 Oct 2016 21:55:47 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 42AE7160AE1
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 26 Oct 2016 23:55:47 +0200 (CEST)
Received: (qmail 15944 invoked by uid 500); 26 Oct 2016 21:55:46 -0000
Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@beam.incubator.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@beam.incubator.apache.org>
List-Post: <mailto:commits@beam.incubator.apache.org>
List-Id: <commits.beam.incubator.apache.org>
Reply-To: dev@beam.incubator.apache.org
Delivered-To: mailing list commits@beam.incubator.apache.org
Received: (qmail 15935 invoked by uid 99); 26 Oct 2016 21:55:46 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2016 21:55:46 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D08CF1A9398
	for <commits@beam.apache.org>; Wed, 26 Oct 2016 21:55:45 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -7.019
X-Spam-Level: 
X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-2.999] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024)
	with ESMTP id RLP2VqY94PnQ for <commits@beam.apache.org>;
	Wed, 26 Oct 2016 21:55:45 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 80D885FBCF
	for <commits@beam.incubator.apache.org>; Wed, 26 Oct 2016 21:55:44 +0000 (UTC)
Received: (qmail 15920 invoked by uid 99); 26 Oct 2016 21:55:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2016 21:55:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A141EE0230; Wed, 26 Oct 2016 21:55:43 +0000 (UTC)
From: tgroh <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-1197-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #1197: [BEAM-839] Remove the PriorityQueue in Ke...
Content-Type: text/plain
Date: Wed, 26 Oct 2016 21:55:43 +0000 (UTC)
archived-at: Wed, 26 Oct 2016 21:55:48 -0000

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1197

    [BEAM-839] Remove the PriorityQueue in KeyedHolds

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Adding and Removing holds is significantly more common than extracting
    the current minimum hold. I assert that the cost of inspecting active holds
    during a refresh is cheaper than maintaining a priority queue 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam wm_manager_perf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1197
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---