Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
From: kennknowles <git@git.apache.org>
To: commits@beam.incubator.apache.org
Reply-To: commits@beam.incubator.apache.org
Message-ID: <git-pr-1179-incubator-beam@git.apache.org>
Subject: [GitHub] incubator-beam pull request #1179: Remove timestamp that stymies smart rebui...
Content-Type: text/plain
Date: Tue, 25 Oct 2016 02:37:32 +0000 (UTC)
archived-at: Tue, 25 Oct 2016 02:37:38 -0000

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1179

    Remove timestamp that stymies smart rebuilds

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This moves our timestamp from a `properties` file to the manifest, where it belongs. Thus it is no longer a change in the `src` tree so rebuilds can be skipped properly. There are some other commits to also speed up the build.
    
    I believe the `-Xpkginfo:always` commit is known to be broken on openJDK 7 but I have left it here to confirm my recollection.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam sdk-timestamp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1179
    
----
commit 16790810c668ecc96b8530347539c7de3367c4c5
Author: Kenneth Knowles <klk@google.com>
Date:   2016-05-04T04:27:44Z

    Remove timestamp in source that caused spurious builds

commit c1ca59148d03db5340e8335de3bb2ba112f4168f
Author: Kenneth Knowles <klk@google.com>
Date:   2016-05-04T04:30:51Z

    Exclude package-info.java from compiled sources list
    
    This is a workaround for [MCOMPILER-205], which causes
    maven-compiler-plugin to always detect stale sources due to sources
    that do not create a class file, such as package-info.java.
    
    An alternative workaround is to add dummy annotations to all
    package-info.java files, which will induce package-info.class
    files.
    
    [MCOMPILER-205](https://issues.apache.org/jira/browse/MCOMPILER-205)

commit 9a133145ecff7c5c4b3a1831bbad93143e701515
Author: Kenneth Knowles <klk@google.com>
Date:   2016-05-04T21:07:22Z

    Add ReleaseInfo to bigtable package and use for User-agent

commit 812ebcf14e622a22d2b7766705a1f935cfd752a8
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-25T02:19:16Z

    Use -Xpkginfo:always flag

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---