Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A8F4200BBE for ; Fri, 28 Oct 2016 00:50:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65D9D160B01; Thu, 27 Oct 2016 22:50:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AEDDE160AF6 for ; Fri, 28 Oct 2016 00:50:31 +0200 (CEST) Received: (qmail 60098 invoked by uid 500); 27 Oct 2016 22:50:30 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 60089 invoked by uid 99); 27 Oct 2016 22:50:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 22:50:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 842341A02C2 for ; Thu, 27 Oct 2016 22:50:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id kiO2dLeqY9n3 for ; Thu, 27 Oct 2016 22:50:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 625175F4EB for ; Thu, 27 Oct 2016 22:50:29 +0000 (UTC) Received: (qmail 57774 invoked by uid 99); 27 Oct 2016 22:47:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 22:47:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 74B7E2C1F56 for ; Thu, 27 Oct 2016 22:47:59 +0000 (UTC) Date: Thu, 27 Oct 2016 22:47:59 +0000 (UTC) From: "Eugene Kirpichov (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-854) ReifyTimestampAndWindows explodes windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Oct 2016 22:50:32 -0000 Eugene Kirpichov created BEAM-854: ------------------------------------- Summary: ReifyTimestampAndWindows explodes windows Key: BEAM-854 URL: https://issues.apache.org/jira/browse/BEAM-854 Project: Beam Issue Type: Bug Reporter: Eugene Kirpichov Assignee: Kenneth Knowles Priority: Critical Commit https://github.com/apache/incubator-beam/commit/b2350417f73ae6c34f849ff0e93d5bd93df3088d changed the fn from accessing the collection of windows to accessing the windows one-by-one, which causes this DoFn to explode them, which (I suppose) hurts performance, since this Fn is quite important: it's a part of GroupByKey in the Spark runner and Direct runner, part of Splittable DoFn, part of GBKViaGBKO, and part of GatherAllPanes. I can see a couple of ways to fix this: - Make this be a primitive transform, with runner-specific support to keep the windows compressed - Allow any DoFn to access the compressed representation explicitly using a Collection parameter I'm personally in favor of the latter because it automatically benefits all runners. -- This message was sent by Atlassian JIRA (v6.3.4#6332)