Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 937C9200BAD for ; Tue, 25 Oct 2016 23:27:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 921BF160AF3; Tue, 25 Oct 2016 21:27:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D9C77160AD8 for ; Tue, 25 Oct 2016 23:27:30 +0200 (CEST) Received: (qmail 763 invoked by uid 500); 25 Oct 2016 21:27:30 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 754 invoked by uid 99); 25 Oct 2016 21:27:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 21:27:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AC688180B0F for ; Tue, 25 Oct 2016 21:27:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gJeOes1CJ86t for ; Tue, 25 Oct 2016 21:27:26 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 933A45FC6A for ; Tue, 25 Oct 2016 21:27:25 +0000 (UTC) Received: (qmail 160 invoked by uid 99); 25 Oct 2016 21:26:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 21:26:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5C7552C14F9 for ; Tue, 25 Oct 2016 21:26:58 +0000 (UTC) Date: Tue, 25 Oct 2016 21:26:58 +0000 (UTC) From: "Thomas Weise (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-829) Apex runner: Add support for metrics and tracking of PAsserts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 25 Oct 2016 21:27:31 -0000 [ https://issues.apache.org/jira/browse/BEAM-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606531#comment-15606531 ] Thomas Weise commented on BEAM-829: ----------------------------------- See comment from [~kenn] https://github.com/apache/incubator-beam/pull/1139 This should really be owned by TestPipeline or something around there, but it seems each runner needs to do it for now: You can see in TestDataflowRunner: There is some counting of how many asserts should run: https://github.com/apache/incubator-beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/testing/TestDataflowRunner.java#L181 And there is some checking that they all ran: https://github.com/apache/incubator-beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/testing/TestDataflowRunner.java#L188 > Apex runner: Add support for metrics and tracking of PAsserts > ------------------------------------------------------------- > > Key: BEAM-829 > URL: https://issues.apache.org/jira/browse/BEAM-829 > Project: Beam > Issue Type: Improvement > Components: runner-apex > Reporter: Thomas Weise > > The runner should support metrics and the test runner should ensure that all assertions have been executed and also tests finish as soon as that's the case rather than waiting for the embedded cluster to terminate by itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)