Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Wed, 26 Oct 2016 17:14:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13015182.1477420138000.91396.1477502098560@Atlassian.JIRA>
In-Reply-To: <JIRA.13015182.1477420138000@Atlassian.JIRA>
References: <JIRA.13015182.1477420138000@Atlassian.JIRA> <JIRA.13015182.1477420138838@arcas>
Subject: [jira] [Commented] (BEAM-821) test_wordcount.sh uses Travis CI's
 default settings.xml, not ours
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 26 Oct 2016 17:15:02 -0000


    [ https://issues.apache.org/jira/browse/BEAM-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609055#comment-15609055 ] 

ASF GitHub Bot commented on BEAM-821:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1180


> test_wordcount.sh uses Travis CI's default settings.xml, not ours
> -----------------------------------------------------------------
>
>                 Key: BEAM-821
>                 URL: https://issues.apache.org/jira/browse/BEAM-821
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-java, sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Jason Kuster
>            Priority: Minor
>
> Our repository contains {{.travis/settings.xml}} so that we control the Maven settings. In particular, this overrides Travis CI's invalid configuration on Linux. 
> But network attempts to an invalid server were noticed - it turns out we aren't using these settings pervasively. Presumably not in our test_wordcount.sh.
> These attempts were partly fixed with a hack using {{sed}} that is unfortunately brittle and completely broken on Travis CI's OSX environment. The better fix is to just use our settings everywhere.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)