Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3D40A200BA8 for ; Mon, 24 Oct 2016 22:56:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3BB3E160AEB; Mon, 24 Oct 2016 20:56:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8232C160AD7 for ; Mon, 24 Oct 2016 22:56:19 +0200 (CEST) Received: (qmail 76179 invoked by uid 500); 24 Oct 2016 20:56:18 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 76170 invoked by uid 99); 24 Oct 2016 20:56:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 20:56:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 53E2BC67D4 for ; Mon, 24 Oct 2016 20:56:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id U3FLs3rWKZth for ; Mon, 24 Oct 2016 20:56:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 5DFC75F576 for ; Mon, 24 Oct 2016 20:56:17 +0000 (UTC) Received: (qmail 73424 invoked by uid 99); 24 Oct 2016 20:54:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 20:54:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 76A5E2C001E for ; Mon, 24 Oct 2016 20:54:58 +0000 (UTC) Date: Mon, 24 Oct 2016 20:54:58 +0000 (UTC) From: "Thomas Groh (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-811) DoFnLifecycleManager may call teardown on a DoFn multiple times MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 24 Oct 2016 20:56:20 -0000 Thomas Groh created BEAM-811: -------------------------------- Summary: DoFnLifecycleManager may call teardown on a DoFn multiple times Key: BEAM-811 URL: https://issues.apache.org/jira/browse/BEAM-811 Project: Beam Issue Type: Bug Components: runner-direct Reporter: Thomas Groh Assignee: Thomas Groh Fix For: 0.4.0-incubating Because the iterator returned by ConcurrentMap.iterator() is weakly consistent, we may obtain a DoFn that is simultaneously removed from the map while iterating in DoFnLifecycleManager#removeAll and removed via the explicit remove call in DoFnLifecycleManger#remove Instead, utilize the Cache#invalidate() method and an appropriate RemovalListener to ensure that DoFn instances that are removed are torn down, and exceptions are appropriately reported. -- This message was sent by Atlassian JIRA (v6.3.4#6332)