Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 73397200BB8 for ; Sat, 29 Oct 2016 03:16:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71FA9160AF5; Sat, 29 Oct 2016 01:16:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BB5A8160AE4 for ; Sat, 29 Oct 2016 03:16:02 +0200 (CEST) Received: (qmail 5044 invoked by uid 500); 29 Oct 2016 01:16:02 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 5035 invoked by uid 99); 29 Oct 2016 01:16:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2016 01:16:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 900F91A99FA for ; Sat, 29 Oct 2016 01:16:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bRJC1vscbubq for ; Sat, 29 Oct 2016 01:16:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 985D65FC18 for ; Sat, 29 Oct 2016 01:15:59 +0000 (UTC) Received: (qmail 4332 invoked by uid 99); 29 Oct 2016 01:15:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2016 01:15:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 914422C2A6C for ; Sat, 29 Oct 2016 01:15:58 +0000 (UTC) Date: Sat, 29 Oct 2016 01:15:58 +0000 (UTC) From: "Manu Zhang (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-800) DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 29 Oct 2016 01:16:03 -0000 [ https://issues.apache.org/jira/browse/BEAM-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617138#comment-15617138 ] Manu Zhang commented on BEAM-800: --------------------------------- Ok. The remaining issues are that {{ParDoEvaluator}} accepts {{DoFn}} now (BEAM-788 ?) and {{DoFnInvoker}} is not {{Serializable}} > DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn > -------------------------------------------------------------- > > Key: BEAM-800 > URL: https://issues.apache.org/jira/browse/BEAM-800 > Project: Beam > Issue Type: Bug > Components: runner-direct > Reporter: Kenneth Knowles > Assignee: Manu Zhang > Priority: Minor > > The {{DirectRunner}}'s support class {{DoFnLifecycleManager}} holds a cache of deserialized {{OldDoFn}} s, now being ported to {{DoFn}} s. But to execute a {{DoFn}} there is another layer of indirection through a {{DoFnInvoker}}, which is the best object to cache here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)