Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Fri, 28 Oct 2016 13:24:58 +0000 (UTC)
From: "Kenneth Knowles (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13014598.1477258381000.117424.1477661098641@Atlassian.JIRA>
In-Reply-To: <JIRA.13014598.1477258381000@Atlassian.JIRA>
References: <JIRA.13014598.1477258381000@Atlassian.JIRA> <JIRA.13014598.1477258381154@arcas>
Subject: [jira] [Commented] (BEAM-800) DoFnLifeCycleManager should hold
 DoFnInvoker, not DoFn/OldDoFn
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 28 Oct 2016 13:25:02 -0000


    [ https://issues.apache.org/jira/browse/BEAM-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615389#comment-15615389 ] 

Kenneth Knowles commented on BEAM-800:
--------------------------------------

Yes, I think it would have to be created sooner. But actually now that I have dug into this, the {{setup()}} and {{teardown()}} methods are not part of {{DoFnRunner}} and I don't think that they should be. So I think just sticking to {{DoFnInvoker}} is the right move here.

> DoFnLifeCycleManager should hold DoFnInvoker, not DoFn/OldDoFn
> --------------------------------------------------------------
>
>                 Key: BEAM-800
>                 URL: https://issues.apache.org/jira/browse/BEAM-800
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Manu Zhang
>            Priority: Minor
>
> The {{DirectRunner}}'s support class {{DoFnLifecycleManager}} holds a cache of deserialized {{OldDoFn}} s, now being ported to {{DoFn}} s. But to execute a {{DoFn}} there is another layer of indirection through a {{DoFnInvoker}}, which is the best object to cache here.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)