Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.incubator.apache.org
Date: Fri, 21 Oct 2016 22:49:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13014094.1477007961000.57082.1477090198335@Atlassian.JIRA>
In-Reply-To: <JIRA.13014094.1477007961000@Atlassian.JIRA>
References: <JIRA.13014094.1477007961000@Atlassian.JIRA> <JIRA.13014094.1477007961576@arcas>
Subject: [jira] [Commented] (BEAM-790) Validate PipelineOptions Default
 annotation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 21 Oct 2016 22:50:03 -0000


    [ https://issues.apache.org/jira/browse/BEAM-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15596590#comment-15596590 ] 

ASF GitHub Bot commented on BEAM-790:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1151


> Validate PipelineOptions Default annotation
> -------------------------------------------
>
>                 Key: BEAM-790
>                 URL: https://issues.apache.org/jira/browse/BEAM-790
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Pei He
>
> It shouldn't allow @Override with @Default annotation, for example the following is broken:
> interface A {
>   @Default.Integer(1)
>   Integer getFoo();
>   void setFoo();
> }
> interface B extends A {
>   @Default.Integer(-1)
>   @Override
>   Integer getFoo();
> }
> It is broken, because PipelineOptions default values are lazily evaluated. And, it will depends on which one of the two following operations happen first:
> options.as(A.class) and options.as(B.class)
> If users want to change the default value, users should do setFoo(...) explicitly.
> It shouldn't allow adding Default annotation as well.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)