Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 79DEF200B8B for ; Tue, 4 Oct 2016 21:28:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 788BE160ACC; Tue, 4 Oct 2016 19:28:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B5E85160AC7 for ; Tue, 4 Oct 2016 21:28:24 +0200 (CEST) Received: (qmail 13351 invoked by uid 500); 4 Oct 2016 19:28:23 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 13342 invoked by uid 99); 4 Oct 2016 19:28:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 19:28:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 85F8FC1D6D for ; Tue, 4 Oct 2016 19:28:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id J7M935gI9C2O for ; Tue, 4 Oct 2016 19:28:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1A2A35FAD5 for ; Tue, 4 Oct 2016 19:28:21 +0000 (UTC) Received: (qmail 13093 invoked by uid 99); 4 Oct 2016 19:28:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 19:28:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 233732C2A65 for ; Tue, 4 Oct 2016 19:28:21 +0000 (UTC) Date: Tue, 4 Oct 2016 19:28:21 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-703) SingletonViewFn might exhaust defaultValue if it's serialized after being used. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Oct 2016 19:28:25 -0000 [ https://issues.apache.org/jira/browse/BEAM-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546394#comment-15546394 ] ASF GitHub Bot commented on BEAM-703: ------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/incubator-beam/pull/1040 > SingletonViewFn might exhaust defaultValue if it's serialized after being used. > -------------------------------------------------------------------------------- > > Key: BEAM-703 > URL: https://issues.apache.org/jira/browse/BEAM-703 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Amit Sela > Assignee: Amit Sela > Priority: Minor > > In https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java#L267 the defaultValue is set to null to avoid decoding over and over I assume. > If the defaultValue is accessed before the the SingletonViewFn is serialized, it will exhaust the encoded value (assigned with null) while losing the transient decoded value. > It'd probably be best to simply check if defaultValue is null before decoding, so that decode will still happen just once, but the encoded data is not lost. -- This message was sent by Atlassian JIRA (v6.3.4#6332)