Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A0BE6200BAD for ; Tue, 25 Oct 2016 14:46:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9F80F160AF3; Tue, 25 Oct 2016 12:46:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E5832160AE6 for ; Tue, 25 Oct 2016 14:46:19 +0200 (CEST) Received: (qmail 74353 invoked by uid 500); 25 Oct 2016 12:46:19 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 74344 invoked by uid 99); 25 Oct 2016 12:46:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 12:46:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AD439C09E8 for ; Tue, 25 Oct 2016 12:46:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sazAyKekRR0J for ; Tue, 25 Oct 2016 12:46:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 91C225FBCD for ; Tue, 25 Oct 2016 12:46:14 +0000 (UTC) Received: (qmail 739 invoked by uid 99); 25 Oct 2016 12:18:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 12:18:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7F9CD2C2A6E for ; Tue, 25 Oct 2016 12:18:59 +0000 (UTC) Date: Tue, 25 Oct 2016 12:18:59 +0000 (UTC) From: "Jason White (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-410) ApproximateQuantiles$QuantileBuffer defines compareTo but not equals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 25 Oct 2016 12:46:20 -0000 [ https://issues.apache.org/jira/browse/BEAM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605173#comment-15605173 ] Jason White commented on BEAM-410: ---------------------------------- +1 > ApproximateQuantiles$QuantileBuffer defines compareTo but not equals > -------------------------------------------------------------------- > > Key: BEAM-410 > URL: https://issues.apache.org/jira/browse/BEAM-410 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Scott Wegner > Assignee: Neelesh Srinivas Salian > Priority: Minor > Labels: findbugs, newbie, starter > > [FindBugs EQ_COMPARETO_USE_OBJECT_EQUALS|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L280]: Class defines compareTo(...) and uses Object.equals() > Applies to: [ApproximateQuanitles$QuantileBuffer|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L627]. > This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)