Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 21ACF200BA1 for ; Mon, 17 Oct 2016 18:59:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1FF83160AEC; Mon, 17 Oct 2016 16:59:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 66889160AE2 for ; Mon, 17 Oct 2016 18:59:19 +0200 (CEST) Received: (qmail 16033 invoked by uid 500); 17 Oct 2016 16:59:18 -0000 Mailing-List: contact commits-help@beam.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.incubator.apache.org Delivered-To: mailing list commits@beam.incubator.apache.org Received: (qmail 16024 invoked by uid 99); 17 Oct 2016 16:59:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 16:59:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2078618068A for ; Mon, 17 Oct 2016 16:59:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1440cZVqeOBu for ; Mon, 17 Oct 2016 16:59:17 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 036915FB20 for ; Mon, 17 Oct 2016 16:59:16 +0000 (UTC) Received: (qmail 15813 invoked by uid 99); 17 Oct 2016 16:58:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 16:58:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 564D12C0073 for ; Mon, 17 Oct 2016 16:58:58 +0000 (UTC) Date: Mon, 17 Oct 2016 16:58:58 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-361) Batch Pub/Sub sink does not set idLabel MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Oct 2016 16:59:20 -0000 [ https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582752#comment-15582752 ] Kenneth Knowles commented on BEAM-361: -------------------------------------- Hi [~venbijjam]. I'll assign this to you. Have you read [the contribution guide|http://beam.apache.org/contribute/contribution-guide/]? [~dhalperi@google.com] or [~millsd@google.com]] may have some feedback on your approach, and then you would code it up and produce a PR with a title starting with {{\[BEAM-361\]}}. > Batch Pub/Sub sink does not set idLabel > --------------------------------------- > > Key: BEAM-361 > URL: https://issues.apache.org/jira/browse/BEAM-361 > Project: Beam > Issue Type: Bug > Components: sdk-java-gcp > Reporter: Daniel Mills > Labels: newbie, starter > > The transform should generate a unique token (must be stable across retries), and set it on outgoing pubsub messages if an idLabel has been set -- This message was sent by Atlassian JIRA (v6.3.4#6332)