beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1217: [BEAM-27] Add setTimer and deleteTimer by...
Date Fri, 28 Oct 2016 13:39:53 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1217

    [BEAM-27] Add setTimer and deleteTimer by ID in TimerInternals

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    I have pulled this commit out of my ongoing work to add timers to `DoFn`, specifically
my branch where I add `DoFnInvoker.invokeOnTimer(<id>, ...)`.
    
    For users, timers will have IDs. This is a step towards that API. I think it is also just
better in most ways, especially for being able to delete timers without having to know exactly
when it was set for.
    
    Before this change, a timer's ID is its `TimeDomain` + `Instant`. Inlining `TimerData`
for this description, I think `setTimer(TimeDomain, Instant)` is OK for setting an anonymous
"wake up" as we use it today, while `deleteTimer(TimeDomain, Instant)` should be removed.
    
    R: @tgroh and @aljoscha and @amitsela 
    
    I am curious about runner-specific thoughts if you have any.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam TimerInternals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1217
    
----
commit 932cb20e64199942369376748faabae548f72df4
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-25T19:28:14Z

    Add setTimer and deleteTimer by ID in TimerInternals
    
    For users, timers will have IDs. This is a step towards
    that API; our current API treats the timer's timestamp
    as its ID, more-or-less. We can leave that API or not. This
    change adds the more general API.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message