beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pabloem <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1200: [BEAM-824] Fixing error message when sdk_...
Date Wed, 26 Oct 2016 22:57:04 GMT
GitHub user pabloem opened a pull request:

    https://github.com/apache/incubator-beam/pull/1200

    [BEAM-824] Fixing error message when sdk_location not provided

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    r: @aaltay can you take a look?
    I tried adding the error strings to `pkg_resources.DistributionNotFound`'s `.args` tuple,
but it seems to have special formatting for them so I couldn't add extra information on the
error message. Let me know how to change the error message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pabloem/incubator-beam sdk-location-err-message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1200
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message