beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1195: Fix up version in SparkRunner dependency ...
Date Wed, 26 Oct 2016 20:06:41 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1195

    Fix up version in SparkRunner dependency on KafkaIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @amitsela 
    
    Two things:
    
    1. Use `${project.version}` for sure. I figure this didn't get bumped in the release.
    2. (not SparkRunner related) put the version in the root pom, by analogy with other modules
in the project.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam SparkRunner-KafkaIO

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1195
    
----
commit cdc5fb280dae95f1384058ddf557d54d07e3e820
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-26T20:03:45Z

    Add default version for beam-sdks-java-io-kafka

commit 705e8a70816e8ab445250cb38aaf550cbae77808
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-26T20:04:24Z

    Use project-wise version in SparkRunner dep on KafkaIO

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message