beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markflyhigh <>
Subject [GitHub] incubator-beam pull request #1189: [BEAM-747] Fix FileChecksumMatcher That I...
Date Tue, 25 Oct 2016 21:46:18 GMT
GitHub user markflyhigh opened a pull request:

    [BEAM-747] Fix FileChecksumMatcher That Inconsistent With Filesystem

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    Add retry in FileChecksumMatcher when following conditions happens:
     - IOException raised from filesystem
     - No file found from output directory
     - number of files found from fs doesn't equal to expected number, which is parsed from
shard name using a name template. Default template "SSS-of-NNN" will be used when no template
is specified.
    Default retry times are 4. Default sleep duration between each retry are 10s.

You can merge this pull request into a Git repository by running:

    $ git pull file-matcher-read-retry

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1189
commit 95392c860d3889b1bee4d5f0ba793465f63a0df2
Author: Mark Liu <>
Date:   2016-10-25T21:21:24Z

    [BEAM-747] Fix FileChecksumMatcher That Inconsistent With FS

commit bc6a89263e4da379abec6e3cdf5bd94ace209d12
Author: Mark Liu <>
Date:   2016-10-25T21:45:46Z

    fixup! Improve Javadoc


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message