beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <>
Subject [GitHub] incubator-beam pull request #1136: [BEAM-27] Add analysis of Timer parameter...
Date Wed, 19 Oct 2016 22:54:28 GMT
GitHub user kennknowles opened a pull request:

    [BEAM-27] Add analysis of Timer parameters for DoFn.ProcessElement

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](
    This PR adds `Timer` parameters. It includes #1102 and #1130. The final commit is the
only one that is new, and can be reviewed independently.
    R: @jkff 
    I will pull in a committer later.

You can merge this pull request into a Git repository by running:

    $ git pull Timer-params

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1136
commit 507cba8f0df44b1c11c7621f00ff492243bdd1f1
Author: Kenneth Knowles <>
Date:   2016-10-14T06:18:40Z

    Tighten up tests for StateId validation

commit 08fdb304a777d981fa3860fcd0270aa40f99da75
Author: Kenneth Knowles <>
Date:   2016-10-14T21:19:59Z

    Fix condition on state/splittable ParDo validation

commit 65eaedbfb628f6eb42d17c16220e973b064608d7
Author: Kenneth Knowles <>
Date:   2016-10-13T20:41:38Z

    Add Timer, TimerId, TimerSpec and TimerSpecs
    These are the simple specifications that describe
    a timer without instantiating it. Consists only of
    the time domain.

commit 0898999f34270a11beddb68e5068c5258ec9ebec
Author: Kenneth Knowles <>
Date:   2016-10-14T02:53:31Z

    Add DoFnSignatures analysis of timer declarations

commit e44e56da62e48f1d763e2b2d46d55a04fbe3596c
Author: Kenneth Knowles <>
Date:   2016-10-18T20:09:57Z

    Reject all timers in ParDo, for now

commit bcb07b534ffff475637d06a14695f38b1e151912
Author: Kenneth Knowles <>
Date:   2016-10-18T21:15:34Z

    fixup! More caveats on Timer javadoc

commit 97aaf9730915d426fd865eeb67793988a8dbdefb
Author: Kenneth Knowles <>
Date:   2016-10-18T21:16:09Z

    fixup! state javadoc

commit ac419d245a7bd3dc9263e61567676e3d92133f9a
Author: Kenneth Knowles <>
Date:   2016-10-18T21:21:41Z

    fixup! refine Timer javadoc

commit 28fbe1890b54e26f7c0d0bc547440af061d1e907
Author: Kenneth Knowles <>
Date:   2016-10-18T22:52:28Z

    fixup! validate is now void

commit dcce856a1fa3d8bde6b47cf200b4444d212de9d2
Author: Kenneth Knowles <>
Date:   2016-10-14T17:51:57Z

    Use the correct State class in DoFnSignatures

commit 70ec03e5cacd272b194589ab3d7ce89e39be7b13
Author: Kenneth Knowles <>
Date:   2016-10-14T18:07:55Z

    Add analysis and validation of State parameters to DoFn.ProcessElement

commit 5883e0c087f1b5642f9349ab099f2eaa82caf8fa
Author: Kenneth Knowles <>
Date:   2016-10-19T22:00:30Z

    Merge remote-tracking branch 'github/pr/1102' into Timer-params

commit bda251e05ffe48873ccaf06f005c3847acd6085b
Author: Kenneth Knowles <>
Date:   2016-10-19T22:02:36Z

    Add analysis of Timer parameters to DoFn.ProcessElement


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message