beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sammcveety <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1134: [BEAM-551] Allow TextIO to accept ValuePr...
Date Wed, 19 Oct 2016 13:56:57 GMT
GitHub user sammcveety opened a pull request:

    https://github.com/apache/incubator-beam/pull/1134

    [BEAM-551] Allow TextIO to accept ValueProvider<String>

    Thinking about testing, is it worth having something sub-integration-test level?  We'd
likely want to add some convenience methods to RVP for that, then.
    
    R: @dhalperi

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sammcveety/incubator-beam sgmc/vp_textio

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1134
    
----
commit 7310c1f5e77f042aa21db046c91ccdb18edec1d8
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-10-16T22:37:51Z

    VP for TextIO

commit 37b89c063b2e24507dfd6725cf89668b135b9774
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-10-17T12:31:51Z

    Add alternate VP getter

commit 9dcf6bfac552737586fc8b0416f1ab0d46291f4b
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-10-17T12:56:41Z

    Add surface methods for VP

commit 9492444b44f331cedd0b8e1a4faec6dc0528d4e2
Author: sammcveety <sam.mcveety@gmail.com>
Date:   2016-10-19T13:40:07Z

    Further improvements to VP handling.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message