beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1118: Restore ReshuffleTriggerTest to SDK
Date Mon, 17 Oct 2016 19:45:53 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1118

    Restore ReshuffleTriggerTest to SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @lukecwik 
    
    This restore was missed in a64acb2f from #1083, where all prior trigger files were restored
for compatibility. We have some internal dependencies lingering.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam ReshuffleTriggerTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1118
    
----
commit 45d3c1ad2122ba335b1f8279d95e79cd7df2661d
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-17T19:44:29Z

    Restore ReshuffleTriggerTest to SDK

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message