beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bjchambers <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1117: Fix SplittableParDoTest
Date Mon, 17 Oct 2016 19:36:12 GMT
GitHub user bjchambers opened a pull request:

    https://github.com/apache/incubator-beam/pull/1117

    Fix SplittableParDoTest

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [*] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [*] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [*] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This required fixing GBKIntoKeyedWorkItems to properly set the coder on
    the primitive, and updating the assertions to match the actual (and
    correct) behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/incubator-beam fix-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1117
    
----
commit 577d04ab0799b18d5c2c88e2250859678f589968
Author: bchambers <bchambers@google.com>
Date:   2016-10-17T19:35:03Z

    Fix SplittableParDoTest
    
    This required fixing GBKIntoKeyedWorkItems to properly set the coder on
    the primitive, and updating the assertions to match the actual (and
    correct) behavior.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message