beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukecwik <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1099: Move the step output ids to use a flat na...
Date Thu, 13 Oct 2016 22:41:00 GMT
GitHub user lukecwik opened a pull request:

    https://github.com/apache/incubator-beam/pull/1099

    Move the step output ids to use a flat namespace.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Also add a logical mapping from tuple tag to the flat namespace for DoFns.
    Note that this is expected to break the Dataflow integration tests until the worker image
is updated.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam flatid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1099.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1099
    
----
commit 0f9b6cae01cead77369e336e2c6d1a39b69e8fe5
Author: Luke Cwik <lcwik@google.com>
Date:   2016-10-13T22:33:49Z

    Move the step output ids to use a flat namespace.
    Also add a logical mapping from tuple tag to the flat namespace for DoFns.

commit f2d2ab825f4e378e45b8b24c773ecc8e40f83338
Author: Luke Cwik <lcwik@google.com>
Date:   2016-10-13T22:40:05Z

    !fixup Fix test to validate that ids are valid int64s.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message