beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chamikaramj <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1090: [BEAM-737][BEAM-738] Updates source API d...
Date Thu, 13 Oct 2016 00:05:20 GMT
GitHub user chamikaramj opened a pull request:

    https://github.com/apache/incubator-beam/pull/1090

    [BEAM-737][BEAM-738] Updates source API documentation to mention that sources should be
immutable and updates existing sources accordingly

    Updates source API documentation to mention that source objects should not be mutated.
    
    Updates  textio._TextSource so that it does not get mutated while reading.
    
    Updates source_test_utils so that sources objects do not get cloned while testing. This
could help to catch sources that erroneously get modified while reading.
    
    Adds reentrancy tests for text and Avro sources.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/incubator-beam update_boundedsource_stateless

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1090.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1090
    
----
commit 5bd56f35d597b142463b1a141e2ac219e6902fc3
Author: Chamikara Jayalath <chamikara@google.com>
Date:   2016-10-12T23:51:20Z

    Updates source API documentation to mention that source objects should not be mutated.
    
    Updates  textio._TextSource so that it does not get mutated while reading.
    
    Updates source_test_utils so that sources objects do not get cloned while testing. This
could help to catch sources that erroneously get modified while reading.
    
    Adds reentracy tests for text and Avro sources.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message