beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1069: [BEAM-732] Only remove Elements that were...
Date Fri, 07 Oct 2016 22:53:22 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1069

    [BEAM-732] Only remove Elements that were pending from Pending Elements

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Update the comparator so elements will only be removed from the
    collection of pending elements if they were formerly added. This ensures
    that elements cannot be removed if a timer delivery has an identical
    timestamp to them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam remove_pending_equality

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1069.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1069
    
----
commit da57ae814bdc9c8d0661c27906f4a6e3c9e7474f
Author: Thomas Groh <tgroh@google.com>
Date:   2016-10-07T22:50:05Z

    Only remove Elements that were pending from Pending Elements
    
    Update the comparator so elements will only be removed from the
    collection of pending elements if they were formerly added. This ensures
    that elements cannot be removed if a timer delivery has an identical
    timestamp to them.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message