beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1049: [BEAM-498] Add DoFnInvoker for OldDoFn, f...
Date Tue, 04 Oct 2016 22:13:47 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1049

    [BEAM-498] Add DoFnInvoker for OldDoFn, for migration ease

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This allows any runner to use `DoFnInvokers.invokerFor(Object)` to be agnostic as to whether
they are running a `DoFn` or `OldDoFn`. Thus, the migration of the runner can occur in advance
of further changes to the SDK and deployment can be independent. For example, a backend need
not know whether it is deserializing a `DoFn` or `OldDoFn`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam DoFnInvokers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1049
    
----
commit 52d74b9cc15268ad29d5f00a04843fa1aeda1c9e
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-04T20:56:13Z

    Add DoFnInvoker for OldDoFn, for migration ease
    
    This allows any runner to use DoFnInvokers.invokerFor(Object) to be
    agnostic as to whether they are running a DoFn or OldDoFn. Thus,
    the migration of the runner can occur in advance of further changes
    to the SDK and deployment can be independent. For example, a backend
    need not know whether it is deserializing a DoFn or OldDoFn.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message