beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <...@git.apache.org>
Subject [GitHub] incubator-beam pull request #1048: Converts KafkaIO builders to @AutoValue
Date Tue, 04 Oct 2016 20:45:48 GMT
GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/1048

    Converts KafkaIO builders to @AutoValue

    This is in the same spirit as https://github.com/apache/incubator-beam/pull/1031, https://github.com/jbonofre/incubator-beam/pull/1
and https://github.com/apache/incubator-beam/pull/1033 . Semantics is unchanged AFAICT. The
only user-visible change is that TypedRead and TypedWrite no longer exist (they were unnecessary
in the first place) - see the trivial changes in test.
    
    R: @rangadi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam kafka-autovalue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1048.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1048
    
----
commit ec3fdd030da1cc2ed2fdd0d16fad0396ef1855a9
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2016-09-29T22:30:10Z

    Converts KafkaIO to AutoValue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message