beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rober...@apache.org
Subject [2/2] incubator-beam git commit: Removing superfluous TODO after unittest is passing
Date Thu, 27 Oct 2016 18:28:56 GMT
Removing superfluous TODO after unittest is passing


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/595bd0d5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/595bd0d5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/595bd0d5

Branch: refs/heads/python-sdk
Commit: 595bd0d537b0977c1098c7dca0c15ef39df674d6
Parents: 03662da
Author: Pablo <pabloem@google.com>
Authored: Thu Oct 27 09:38:59 2016 -0700
Committer: Robert Bradshaw <robertwb@google.com>
Committed: Thu Oct 27 11:28:33 2016 -0700

----------------------------------------------------------------------
 sdks/python/apache_beam/dataflow_test.py | 3 ---
 1 file changed, 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/595bd0d5/sdks/python/apache_beam/dataflow_test.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/dataflow_test.py b/sdks/python/apache_beam/dataflow_test.py
index cc3a526..f96e8af 100644
--- a/sdks/python/apache_beam/dataflow_test.py
+++ b/sdks/python/apache_beam/dataflow_test.py
@@ -199,9 +199,6 @@ class DataflowTest(unittest.TestCase):
         'ClassifyNumbers',
         lambda x: [x, SideOutputValue('even' if x % 2 == 0 else 'odd', x)]
     ).with_outputs()
-    # TODO(silviuc): Revisit this test to check for undeclared side outputs.
-    # This should work with .with_outputs() without any tags declared and
-    # the results[None] should work also.
     assert_that(results[None], equal_to([1, 2, 3, 4]))
     assert_that(results.odd, equal_to([1, 3]), label='assert:odd')
     assert_that(results.even, equal_to([2, 4]), label='assert:even')


Mime
View raw message