beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mitch Shanklin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-860) Move Apache RAT license check out of release profile
Date Mon, 31 Oct 2016 17:19:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622776#comment-15622776
] 

Mitch Shanklin commented on BEAM-860:
-------------------------------------

That makes sense. I guess I just have a few questions.

1. Do we have sufficient consensus on this among the committers, or should I post something
to the beam-dev e-mail list?
2. "other similar things" seem to me to probably be:
a. test coverage
b. find bugs
Let me know if that seems incorrect.
3. It looks like the profiles Jenkins precommit uses currently are: "release,include-runners,jenkins-precommit"
The phases/goals are: clean install coveralls:report. So mvn clean install coveralls:report
 -P release,include-runners,jenkins-precommit would be the current command to run, which is
not the most concise. If we changed release, include-runners and jenkins-precommit to activate
via a property, we could do something like 'mvn clean install coveralls:report -Dprecommit=true'
Not sure if there is anything annoying associated with running install locally. Likewise not
sure how often you see failures in install phase but not verify or earlier.

Going to discard the current PR, not anything in there that will be used.

> Move Apache RAT license check out of release profile
> ----------------------------------------------------
>
>                 Key: BEAM-860
>                 URL: https://issues.apache.org/jira/browse/BEAM-860
>             Project: Beam
>          Issue Type: Improvement
>            Reporter: Mitch Shanklin
>            Assignee: Mitch Shanklin
>            Priority: Minor
>
> Currently Apache RAT only checks licenses as a part of the release profile. Since the
contributor's guide advises users to run 'mvn clean verify' without the release profile locally,
this means that missing licenses on files are caught by Jenkins when they could be caught
locally, saving a cycle.
> Since RAT runs quickly, there doesn't seem to be a great reason to keep that in the release
profile. Seems similar to checkstyle in many respects, which is not part of the release profile.
> See https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048 for discussion
of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message