beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-860) Move Apache RAT license check out of release profile
Date Mon, 31 Oct 2016 16:05:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622575#comment-15622575
] 

Daniel Halperin commented on BEAM-860:
--------------------------------------

 I think we want to keep the default `mvn verify` profile to only the subsets of commands
that a Beam **user** wants to run. To that end:

* we should continue leaving RAT off the default profile
* we should remove checkstyle and other similar things
* we should document very concisely in the contribution guide what command Jenkins precommit
runs (maybe it should be `-Pprecommit` ?) for contributors who want to test locally

> Move Apache RAT license check out of release profile
> ----------------------------------------------------
>
>                 Key: BEAM-860
>                 URL: https://issues.apache.org/jira/browse/BEAM-860
>             Project: Beam
>          Issue Type: Improvement
>            Reporter: Mitch Shanklin
>            Assignee: Mitch Shanklin
>            Priority: Minor
>
> Currently Apache RAT only checks licenses as a part of the release profile. Since the
contributor's guide advises users to run 'mvn clean verify' without the release profile locally,
this means that missing licenses on files are caught by Jenkins when they could be caught
locally, saving a cycle.
> Since RAT runs quickly, there doesn't seem to be a great reason to keep that in the release
profile. Seems similar to checkstyle in many respects, which is not part of the release profile.
> See https://github.com/apache/incubator-beam/pull/1199#issuecomment-256802048 for discussion
of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message