beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-857) Beam's checkstyle.xml broken for Checkstyle-IDEA
Date Fri, 28 Oct 2016 17:46:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616059#comment-15616059
] 

ASF GitHub Bot commented on BEAM-857:
-------------------------------------

GitHub user swegner opened a pull request:

    https://github.com/apache/incubator-beam-site/pull/55

    [BEAM-857] Add IntelliJ Checkstyle documentation

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/swegner/incubator-beam-site intellij

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam-site/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit db18665a9bfbb3ca2e492c9afb9f8519c9a61596
Author: Scott Wegner <swegner@google.com>
Date:   2016-10-28T17:44:13Z

    Add IntelliJ Checkstyle documentation

----


> Beam's checkstyle.xml broken for Checkstyle-IDEA
> ------------------------------------------------
>
>                 Key: BEAM-857
>                 URL: https://issues.apache.org/jira/browse/BEAM-857
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Scott Wegner
>            Priority: Minor
>
> Because the suppressions file is specified by property, it is not a valid {{checkstyle.xml}}
for tools that do not set the property, which includes IntelliJ's plugin (as far as I could
tell from briefly trying to load it). I guess this has something to do with supporting both
Maven and Eclipse? Ideally, the checkstyle file would work standalone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message