beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <>
Subject [jira] [Created] (BEAM-854) ReifyTimestampAndWindows explodes windows
Date Thu, 27 Oct 2016 22:47:59 GMT
Eugene Kirpichov created BEAM-854:

             Summary: ReifyTimestampAndWindows explodes windows
                 Key: BEAM-854
             Project: Beam
          Issue Type: Bug
            Reporter: Eugene Kirpichov
            Assignee: Kenneth Knowles
            Priority: Critical

changed the fn from accessing the collection of windows to accessing the windows one-by-one,
which causes this DoFn to explode them, which (I suppose) hurts performance, since this Fn
is quite important: it's a part of GroupByKey in the Spark runner and Direct runner, part
of Splittable DoFn, part of GBKViaGBKO, and part of GatherAllPanes.

I can see a couple of ways to fix this:
- Make this be a primitive transform, with runner-specific support to keep the windows compressed
- Allow any DoFn to access the compressed representation explicitly using a Collection<BoundedWindow>

I'm personally in favor of the latter because it automatically benefits all runners.

This message was sent by Atlassian JIRA

View raw message