beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-839) The DirectRunner slows down significantly as the number of keys increases
Date Wed, 26 Oct 2016 23:37:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610052#comment-15610052
] 

ASF GitHub Bot commented on BEAM-839:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1202

    [BEAM-839] Use a NavigableSet Instead of a PriorityQueue in WatermarkManager

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This removes an O(n) call to remove, replacing it with an O(log(n))
    call. This significantly improves scaling behavior of the DirectRunner

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam navigable_set_wmm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1202
    
----
commit af928bb6dcf880853b7a5493a54fc5b61180e172
Author: Thomas Groh <tgroh@google.com>
Date:   2016-10-26T23:35:31Z

    Use a NavigableSet Instead of a PriorityQueue in WatermarkManager
    
    This removes an O(n) call to remove, replacing it with an O(log(n))
    call. This significantly improves scaling behavior of the DirectRunner

----


> The DirectRunner slows down significantly as the number of keys increases
> -------------------------------------------------------------------------
>
>                 Key: BEAM-839
>                 URL: https://issues.apache.org/jira/browse/BEAM-839
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> For example, running WordCount on KingLear takes approximately 10 seconds, while running
WordCount on all of Shakespeare takes approximately 5 minutes. Most of this time is spent
with the transforms unable to make progress, as the time is spent updating the minimum hold.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message