beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Weise (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-829) Apex runner: Add support for metrics and tracking of PAsserts
Date Tue, 25 Oct 2016 21:26:58 GMT

    [ https://issues.apache.org/jira/browse/BEAM-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606531#comment-15606531
] 

Thomas Weise commented on BEAM-829:
-----------------------------------

See comment from [~kenn]

https://github.com/apache/incubator-beam/pull/1139

This should really be owned by TestPipeline or something around there, but it seems each runner
needs to do it for now: You can see in TestDataflowRunner:

There is some counting of how many asserts should run: https://github.com/apache/incubator-beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/testing/TestDataflowRunner.java#L181

And there is some checking that they all ran: https://github.com/apache/incubator-beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/testing/TestDataflowRunner.java#L188

> Apex runner: Add support for metrics and tracking of PAsserts
> -------------------------------------------------------------
>
>                 Key: BEAM-829
>                 URL: https://issues.apache.org/jira/browse/BEAM-829
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-apex
>            Reporter: Thomas Weise
>
> The runner should support metrics and the test runner should ensure that all assertions
have been executed and also tests finish as soon as that's the case rather than waiting for
the embedded cluster to terminate by itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message