beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-822) SDK build writes timestamp to source tree, causing spurious builds
Date Thu, 27 Oct 2016 03:56:59 GMT

    [ https://issues.apache.org/jira/browse/BEAM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610566#comment-15610566
] 

ASF GitHub Bot commented on BEAM-822:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1205

    [BEAM-822] Add meaningless annotation to package-info.java to avoid spurious rebuilds

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Together with #1204 this will eliminate spurious rebuilds of the Java SDK.
    
    R: @lukecwik  and @swegner does this violate anything you had in mind for `build-tools`?
It could also go in the core SDK, I suppose. It is nice to put it somewhere that users will
not depend on it. (so if they obey IWYU it is not part of the API)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam package-info-annotations

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1205
    
----
commit 6d4a2635199550fa361c470e788ff7f7be4084b0
Author: Kenneth Knowles <klk@google.com>
Date:   2016-10-27T03:51:51Z

    Add meaningless annotation to package-info.java to avoid spurious rebuilds

----


> SDK build writes timestamp to source tree, causing spurious builds
> ------------------------------------------------------------------
>
>                 Key: BEAM-822
>                 URL: https://issues.apache.org/jira/browse/BEAM-822
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> The SDK build puts the build timestamp into {{sdk.properties}}. To have a timestamp that
does not break incremental build, the right place for it is in the manifest of the built artifact.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message